From c4c081362edaf6afcfeb0d6bc6bb554b38980f53 Mon Sep 17 00:00:00 2001
From: Jake Kasper <jake.kasper@hpe.com>
Date: Fri, 24 Apr 2026 11:45:37 -0400
Subject: [PATCH] fix service to pass environment variables

---
 config/p5g-marvis.service | 27 ++++++++++++++++++---------
 1 file changed, 18 insertions(+), 9 deletions(-)

diff --git a/config/p5g-marvis.service b/config/p5g-marvis.service
index 738ad2e..8b2592b 100644
--- a/config/p5g-marvis.service
+++ b/config/p5g-marvis.service
@@ -8,21 +8,30 @@ Type=simple
 Restart=always
 RestartSec=5
 TimeoutStartSec=0
+Environment=MARVIS_PROMETHEUS_URL=http://127.0.0.1:9090
+Environment=MARVIS_PROMETHEUS_PREFIX=/prometheus
+Environment=MARVIS_ALERTMANAGER_URL=http://127.0.0.1:9093
+Environment=MARVIS_AI_MODE=rule
+Environment=MARVIS_OPENAI_API_KEY=
+Environment=MARVIS_OPENAI_BASE_URL=https://api.openai.com
+Environment=MARVIS_OPENAI_MODEL=gpt-4o-mini
+Environment=MARVIS_OLLAMA_URL=http://127.0.0.1:11434
+Environment=MARVIS_OLLAMA_MODEL=llama3
 EnvironmentFile=-/etc/p5g-marvis/marvis.env
 
 ExecStartPre=-/usr/bin/docker rm -f p5g-marvis
 ExecStart=/usr/bin/docker run \
   --name p5g-marvis \
   --network host \
-  --env MARVIS_PROMETHEUS_URL=${MARVIS_PROMETHEUS_URL:-http://127.0.0.1:9090} \
-  --env MARVIS_PROMETHEUS_PREFIX=${MARVIS_PROMETHEUS_PREFIX:-/prometheus} \
-  --env MARVIS_ALERTMANAGER_URL=${MARVIS_ALERTMANAGER_URL:-http://127.0.0.1:9093} \
-  --env MARVIS_AI_MODE=${MARVIS_AI_MODE:-rule} \
-  --env MARVIS_OPENAI_API_KEY=${MARVIS_OPENAI_API_KEY:-} \
-  --env MARVIS_OPENAI_BASE_URL=${MARVIS_OPENAI_BASE_URL:-https://api.openai.com} \
-  --env MARVIS_OPENAI_MODEL=${MARVIS_OPENAI_MODEL:-gpt-4o-mini} \
-  --env MARVIS_OLLAMA_URL=${MARVIS_OLLAMA_URL:-http://127.0.0.1:11434} \
-  --env MARVIS_OLLAMA_MODEL=${MARVIS_OLLAMA_MODEL:-llama3} \
+  --env MARVIS_PROMETHEUS_URL \
+  --env MARVIS_PROMETHEUS_PREFIX \
+  --env MARVIS_ALERTMANAGER_URL \
+  --env MARVIS_AI_MODE \
+  --env MARVIS_OPENAI_API_KEY \
+  --env MARVIS_OPENAI_BASE_URL \
+  --env MARVIS_OPENAI_MODEL \
+  --env MARVIS_OLLAMA_URL \
+  --env MARVIS_OLLAMA_MODEL \
   p5g-marvis:latest
 ExecStop=/usr/bin/docker stop p5g-marvis